Ask HN: Do you rewrite pull requests?
by phendrenad2 on Hacker News.
Just wondering how other open-source developers deal with valid by badly-written pull requests. I usually work closely with the PR author, giving them multiple rounds of suggestions until it’s up to our project’s coding standards. Sometimes the PR author “drops out” of the process in frustration, as they were just trying to give us a quick fix, and didn’t necessarily want to do a lot of work. In those cases, I usually thank them, and rewrite the PR (or heavily modify it). But I’m hesitant to do this in all cases, because often the PR author is excited to see their name as part of the contributors list, and/or to see their own code used in the project. How so you deal with this kind of thing?